docs: Refine and fix nits in README #4220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
kelbrown20
force-pushed
the
refine-readme
branch
from
16300dc to
5599749
Compare
ktdreyer
previously requested changes
Nov 24, 2025
kelbrown20
force-pushed
the
refine-readme
branch
from
5599749 to
7c601b3
Compare
kelbrown20
requested review from
ashwinb,
bbrowning,
cdoern,
ehhuang,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
kelbrown20
force-pushed
the
refine-readme
branch
4 times, most recently
from
29aa585 to
03e6cc8
Compare
Collaborator
|
@kelbrown20 can you look at the precommit error? Please run it locally |
Contributor
Author
|
@leseb Yeah i'm looking into that and a bit unsure whats going on bc its passing locally but not in the PR. |
Collaborator
|
@kelbrown20 it looks like pre-commit is adding back some of the indentation changes you made, they might be purposeful for formatting? |
Contributor
Author
|
I think you're right bc it was the pre-commit that added those indentations to the PR, so should this be okay? |
Contributor
|
@kelbrown20 please run pre-commit locally. Without that, it will be much harder to get the whitespacing right. You need |
kelbrown20
force-pushed
the
refine-readme
branch
3 times, most recently
from
797f371 to
02d1be3
Compare
kelbrown20
force-pushed
the
refine-readme
branch
from
02d1be3 to
eee65fc
Compare
ashwinb
approved these changes
Dec 2, 2025
r-bit-rry
pushed a commit
to r-bit-rry/llama-stack
that referenced
this pull request
Dec 3, 2025
Description: Refines and fixes some nits in the Llama stack readme
r-bit-rry
pushed a commit
to r-bit-rry/llama-stack
that referenced
this pull request
Dec 4, 2025
Description: Refines and fixes some nits in the Llama stack readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Refines and fixes some nits in the Llama stack readme